search

juhp / fbrnch

Tool to update fedora packages branches
https://hackage.haskell.org/package/fbrnch
GNU General Public License v2.0
23 stars 3 forks source link

create-review: missing FAS username #42

Open farchord opened 1 year ago

farchord commented 1 year ago

This is what gets output by the script:

Spec URL: (URL) SRPM URL: (SRPM URL)

Description: Classes to read and interact with KColorScheme.

This is what the system would usually expect:

Spec URL: (URL) SRPM URL: (SRPM URL) Description: Classes to read and interact with KColorScheme. Fedora Account: farchord

Aside from that, works great!

farchord commented 1 year ago

Sorry, the actual syntax should be:

Spec URL: SRPM URL: Description: Fedora Account System Username:

According to https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format=fedora-review

juhp commented 1 year ago

Thanks for this

juhp commented 1 year ago

I think an example created with fedora-create-review would be helpful (more authoritative).

Because the description is often more than one line (the Summary goes into the RR summary field)

farchord commented 1 year ago

I think an example created with fedora-create-review would be helpful (more authoritative).

Because the description is often more than one line (the Summary goes into the RR summary field)

From experience, if the description is multi-lined, that works fine as far as requesting repos. I'm guessing the "Fedora Account System Username: " line has a certain degree of importance but I don't think there's a restriction as to where it should be.

farchord commented 1 year ago

As long as it's on a line on it's own I mean.

juhp commented 1 year ago

Yeah, anyway i will try to find an example just for reference.

TBH I don't think the FAS-id line is a hard requirement (as in a blocker), but I agree it is good to have and easy enough to do.

juhp commented 2 months ago

This should get fixed in 1.5.1