create-review: The review request is not in the proper syntax (Missing FAS username)

[farchord]

This is what gets output by the script:

Spec URL: (URL) SRPM URL: (SRPM URL)

Description: Classes to read and interact with KColorScheme.

This is what the system would usually expect:

Spec URL: (URL) SRPM URL: (SRPM URL) Description: Classes to read and interact with KColorScheme. Fedora Account: farchord

Aside from that, works great!

[farchord]

Sorry, the actual syntax should be:

Spec URL: SRPM URL: Description: Fedora Account System Username:

According to https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format=fedora-review

[juhp]

Thanks for this

[juhp]

I think an example created with fedora-create-review would be helpful (more authoritative).

Because the description is often more than one line (the Summary goes into the RR summary field)

[farchord]

I think an example created with fedora-create-review would be helpful (more authoritative).

Because the description is often more than one line (the Summary goes into the RR summary field)

From experience, if the description is multi-lined, that works fine as far as requesting repos. I'm guessing the "Fedora Account System Username: " line has a certain degree of importance but I don't think there's a restriction as to where it should be.

[farchord]

As long as it's on a line on it's own I mean.

[juhp]

Yeah, anyway i will try to find an example just for reference.

TBH I don't think the FAS-id line is a hard requirement (as in a blocker), but I agree it is good to have and easy enough to do.