search

juhp / pkgtreediff

Tool for comparing rpm package trees
https://hackage.haskell.org/package/pkgtreediff
GNU General Public License v3.0
5 stars 2 forks source link

add koji tag location support #4

Closed TristanCacqueray closed 4 years ago

TristanCacqueray commented 4 years ago

This change enables comparing koji tag using a new syntax: tag@kojihub

juhp commented 4 years ago

Okay, cool, I just noticed this and will try to review this tomorrow.

I have pondered before about syntax for interesting new sources, eg ssh (but wondering if abc@xyz may be too generic, though not sure what would be better: maybe using (pseudo)-uri's like koji://tag@hub perhaps?) Anyway we can think a little on this before releasing it.

TristanCacqueray commented 4 years ago

Oh right, I forgot to mention I wasn't a big fan of the tag@hub syntax :-)

The issue with using a koji:// scheme is that it doesn't look great for fully qualified hub, e.g.: koji://sf-3.5-el7@http://koji.softwarefactory-project.io/kojihub

Though I can't think of a better solution. Let me do the change.

juhp commented 4 years ago

The issue with using a koji:// scheme is that it doesn't look great for fully qualified hub, e.g.: koji://sf-3.5-el7@http://koji.softwarefactory-project.io/kojihub

Hmm yea, good point - never seen url in uri before...

Guess it is not worse than xml embedded in xml, lol (Me looks into Koji rpc' eyes... ;o)

TristanCacqueray commented 4 years ago

Another solution would be a simpler koji: or koji= prefix.

juhp commented 4 years ago

Basically looks good to me: though I haven't tried it.

The issue with using a koji:// scheme is that it doesn't look great for fully qualified hub, e.g.: koji://sf-3.5-el7@http://koji.softwarefactory-project.io/kojihub

How about koji://sf-3.5-el7@koji.softwarefactory-project.io/kojihub? Could that be sufficient?

Or possibly koji://koji.softwarefactory-project.io/kojihub#sf-3.5-el7 ?? Not sure which uri scheme is most natural.

TristanCacqueray commented 4 years ago

Removing the koji http scheme can be an issue too when the service is only http or https. I think that's quite a special case, and koji://tag-name@scheme://url looks like a good compromise to me.

juhp commented 4 years ago

Thanks, looking forward to play with this later :+1: