juice-shop / juice-shop-ctf

Tool to export Juice Shop challenges and hints in data format compatible with CTFd, RootTheBox or FBCTF
http://owasp-juice.shop
MIT License
410 stars 116 forks source link

[๐Ÿ›] paid insertHints and insertHintUrls not working when set from yaml config #99

Closed jamiemccrindle closed 4 years ago

jamiemccrindle commented 4 years ago

:bug: Bug report

Description

Setting these values:

insertHints: paid
insertHintUrls: paid

doesn't result in a cost being assigned to hints.

Is this a regression?

N/A

:microscope: Minimal Reproduction

ctfFramework: CTFd
juiceShopUrl: https://juice-shop.herokuapp.com
ctfKey: https://raw.githubusercontent.com/bkimminich/juice-shop/master/ctf.key
insertHints: paid
insertHintUrls: paid

:deciduous_tree: Your Environment

debian 10 node 14

Additional Information

N/A

github-actions[bot] commented 4 years ago

Thanks a lot for opening your first issue with us! ๐Ÿงก We'll get back to you shortly! โณ If it was a Support Request, please check our extensive CTF manual first. Also, please consider asking on the community chat next time! ๐Ÿ’ฌ

bkimminich commented 4 years ago

Oh wow, nice find. Seems either not many people use paid hints and/or the config file option... ๐Ÿ˜‚

I'll review and merge soon and will publish it as a bugfix release. Thanks! ๐Ÿ‘

(Send me an email with your address and you'll get a little thank-you-sticker-pack!)