search

juice-shop / juice-shop

OWASP Juice Shop: Probably the most modern and sophisticated insecure web application
https://owasp-juice.shop
MIT License
10.38k stars 10.75k forks source link

[🏗️] Remove support for Node.js 14 (until end of April 2023) #1941

Closed bkimminich closed 1 year ago

bkimminich commented 1 year ago

As Node.js 14 goes end-of-life on April 30th 2023 Juice Shop should remove support for it by then. Unless the legacy linux/arm/v7 Docker images can be built on Node.js 16+ by then, these need to be removed as well.

image

Subhajit009iitr commented 1 year ago

Hey, I am a beginner in the world of Open Source Contribution and I was looking for Good First issues. This one seemed to me a pretty interesting one. I would love to contribute to solving this issue if you would allow me to do so.

bkimminich commented 1 year ago

Node 14 support should not be removed before April, but if you want to take a look into ARMv7 support with a Node 16 or higher Docker base image, that'd be highly appreciated.

Subhajit009iitr commented 1 year ago

Ya I would love to.

Freedisch commented 1 year ago

Hi @bkimminich, I wonder if this issue should not be closed since you already updated the node version for the docker image and removed the ARMv docker image.

bkimminich commented 1 year ago

Not yet, as you can still launch JS locally with Node 14 and 15. The next major release will prevent that behavior, and then the full scope of this issue is solved.

Aarav238 commented 1 year ago

I want to work on it as I am looking for good first issues , I have knowledge of containerization as well . Please assign this issue to me. @bkimminich

bkimminich commented 1 year ago

I want to work on it as I am looking for good first issues , I have knowledge of containerization as well . Please assign this issue to me. @bkimminich

Happy to! But please keep in mind that the only thing to work on here is finding out about a possible arm/v7 image with Node.js 16 or even better 18 as runtime.

If it's working with the new distroless base image we moved to, that'd be amazing, but I think there were some issues building on 32bit. Feel free to play with it and see how far you get.

Aarav238 commented 1 year ago

we have to make changes in DockerFile right ?

bkimminich commented 1 year ago

You could try using the existing Dockerfile on a 32bit ARM system and if it doesn't work (which is highly likely) you could try to create a separate one which does work.

Up to https://github.com/juice-shop/juice-shop/tree/v14.4.0 we had a Dockerfile.arm for that which was based on Node 14. If you can come up with an image based on Node 18 instead that actually builds and works under 32bit ARM, its a huge success.