juicedata / juicefs

JuiceFS is a distributed POSIX file system built on top of Redis and S3.
https://juicefs.com
Apache License 2.0
10.06k stars 888 forks source link

stats cmd should be robust enough to handle metrics with multiple labels #4941

Closed polyrabbit closed 2 weeks ago

polyrabbit commented 2 weeks ago

When objects sink to cold storage, we will have multiple storage_class labels in object_request_data_bytes metric, which causes the stats cmd shows less object bandwidth than actual.

The stats cmd should be robust to this situation - it's counter-intuitive for a newcomer to realize that adding a new label to those metrics will cause the stats cmd to function incorrectly.