juicermv / GTA-GPS-Redux

A complete GPS mod for Grand Theft Auto San Andreas
20 stars 3 forks source link

Should not use traffic lane direction #8

Closed JuniorDjjr closed 1 year ago

JuniorDjjr commented 1 year ago

I'm glad you're continuing this project, as it's something really important for the game.

But the idea of respecting lane direction is terrible. This should be an option in the .ini, and disabled by default. It is only useful for people who play the game respecting the traffic laws (roleplay). And even in this case it's bad, because the game's map wasn't designed for that.

juicermv commented 1 year ago

Perhaps I could calculate both and pick the shortest one of the two (in addition to having the option to choose one or the other). Will implement.

JuniorDjjr commented 1 year ago

Perhaps I could calculate both and pick the shortest one of the two (in addition to having the option to choose one or the other). Will implement.

What's the point of calculating both and finding the closest?

You would be calculating X and Y (2 lanes), and then only X (only valid dir lane), but in X and Y you have already calculated X.

That is, there is no way X and Y give a longer path than only X.

juicermv commented 1 year ago

I meant I calculate both and choose the one that's shortest meaning I calculate once with traffic direction enabled, and then once without it, and then pick the shortest of the two.

JuniorDjjr commented 1 year ago

Yes I understood that.

Traffic direction enabled: X (only correct lane) Traffic direction disabled: XY (correct and incorrect lane)

If you calculate only "disabled", you are already calculated both sides, then for sure you will have the shortest way.

juicermv commented 1 year ago

Oh that's right lol, my mistake.

juicermv commented 1 year ago

Re-opening this so it shows up on the milestone thing.

juicermv commented 1 year ago

Added the toggle in the config but it's gonna be on by default as most people seem to prefer it that way (judging by the comments on mixmods). Releasing soon.