search

juicycleff / casbin-mongodb-adapter

Pure MongoDB adapter for Casbin
MIT License
9 stars 14 forks source link

Why force users to install with yarn? #2

Closed fchristl closed 4 years ago

fchristl commented 4 years ago

I am working on a project where I'd like to use this package. However, when trying to install with npm, the (intended) error message pops up: casbin-mongo-adapter must be installed with Yarn.

Is there any reason behind this rather than a a preference for Yarn? I work in an all-npm environment (including our CI servers, all other team members' development environments, ...), so changing to Yarn for just this one package is not an option.

If there is no other reason rather than a preference for Yarn, would you agree to removing the preinstall hook?

Update: I find this especially confusing as the README states to install using npm.

hsluoyz commented 4 years ago

I think we can support NPM.

fchristl commented 4 years ago

Here's a PR that addresses the issue plus two minor build problems: https://github.com/juicycleff/casbin-mongodb-adapter/pull/3

fchristl commented 4 years ago

Hi @hsluoyz , did you already have a chance to take a look at my PR? It'd be great if we could get a new version published that allows installing via NPM.

hsluoyz commented 4 years ago

I cannot merge it. Is the owner @juicycleff here?

juicycleff commented 4 years ago

@fchristl @hsluoyz I'm making a release for this now

juicycleff commented 4 years ago

And sorry for the delay, I was quite busy

juicycleff commented 4 years ago

Just made a release now, closing this. Also included some minor adjustment to the mongo collection and database naming

fchristl commented 4 years ago

Great, thank you so much