search

juicycleff / flutter-unity-view-widget

Embeddable unity game engine view for Flutter. Advance demo here https://github.com/juicycleff/flutter-unity-arkit-demo
BSD 3-Clause "New" or "Revised" License
2.13k stars 518 forks source link

Feature Request: UPM Support for Unity Package #821

Closed k0uhe1D closed 1 year ago

k0uhe1D commented 1 year ago

@juicycleff @timbotimbo @RoyalCoder88

Hello,

I hope this message finds you well. I would like to request a feature enhancement for the current Unity package distributed through this repository. Specifically, I am interested in adding support for Unity's Package Manager (UPM).

The main reasons for wanting to implement UPM support are as follows: • To make library updates more convenient and streamlined • To avoid placing external libraries directly under the Unity project's Assets folder as much as possible

Ideal distribution format

However, I noticed that the original source code is not included in this repository. In order to proceed with the UPM implementation, it would be extremely helpful if you could kindly make the source code publicly available.

I believe this enhancement will greatly benefit the community and improve the usability of this library. Thank you for your time and consideration, and I look forward to your response.

Kind regards, kouhei.

k0uhe1D commented 1 year ago

Note: Another option could be to unpack the Unity package and add its contents to a Git repository for UPM support. While this may not be the most elegant solution, it would still achieve the desired goal.

RoyalCoder88 commented 1 year ago

Hi @k0uhe1D ,

I think this is an amazing idea, we are not the original authors of this package, but we will support this package as much as we can, I will contact the author to add you as well as the admin if you agree to support and develop this package, as well about your proposal. Good luck!

timbotimbo commented 1 year ago

However, I noticed that the original source code is not included in this repository.

All code is in the repository. The source for the unitypackage file is in the DemoApp, FlutterUnityIntegration folder.

Regarding UPM: This was requested before in #713, #401.
Juicycleff mentioned back in 2021 (#401) that his attempt got rejected from the asset store.

But even without the asset store, you could still import a package using a git url.

The downside to using a UPM package is that it gets harder to edit the package code in your Unity project. This plugin is not stable enough to simply import and forget it. You will very likely have to customize the export script to fix something, which would require using a custom package again.