Add raw parameter for Github files to images in the readme

juicycleff / flutter-unity-view-widget

Embeddable unity game engine view for Flutter. Advance demo here https://github.com/juicycleff/flutter-unity-arkit-demo

BSD 3-Clause "New" or "Revised" License

2.09k stars 505 forks source link

Add raw parameter for Github files to images in the readme #888

Closed rolinbos closed 8 months ago

rolinbos commented 8 months ago

Description

Some images in the readme are not loading from Github. To see the images the raw parameter needs to be added to them.

Type of Change

Documentation change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[x] 📝 Documentation
[ ] 🗑️ Chore

timbotimbo commented 8 months ago

The broken images on pub.dev are because they use a relative url instead of absolute. Multiple other images do work without having ?raw=true added.

If you check them in the inspector, you see that there is no github url at all. <img src="files/change_target_membership_data_folder.png" width="400">

This was already fixed here on github before by making them absolute urls. It is just the plugin on pub.dev that hasn't received an update in ages.

rolinbos commented 8 months ago

@timbotimbo Oh yes of course. I overlooked it.