juju-solutions / bigtop

Mirror of Apache Bigtop
Apache License 2.0
0 stars 2 forks source link

Zookeeper bind address #30

Closed pengale closed 8 years ago

pengale commented 8 years ago

These are fixes to Zookeeper, which do two things:

1) Allow an operator to restrict the interface/ip that the client listens on, in secure environments. 2) Sets the series to xenial, so that we can promulgate to the store without clobbering things.

This is the first PR in a chain of three. The next PR is against upstream master, and implements puppet fixes to support our changes: https://github.com/apache/bigtop/pull/135/files

The last PR in the chain is the patch to the bigtop base layer, which also contains a fix for installing the bigtop zookeeper deb on xenial: https://github.com/juju-solutions/layer-apache-bigtop-base/pull/33

kwmonroe commented 8 years ago

LGTM

kwmonroe commented 8 years ago

fwiw, also merged the 3rd PR referenced here (juju-solutions/layer-apache-bigtop-base#33). the upstream PR needs some ack from upstreams, but that won't block us from providing this functionality in our zk charm.