search

juju-solutions / charmguardian

Testing tool for Juju charm, bundles, and charm/bundle merge proposals.
3 stars 3 forks source link

Runs charm proof in such a way that it will emit spurious warnings #3

Closed abentley closed 10 years ago

abentley commented 10 years ago

When charm proof is run as a bundle test, a warning like this is always emitted:

W: metadata name (mediawiki) must match directory name (cs_precise_mediawiki-10) exactly for local deployment.

This is because proof is being run in deployer's cache directory, e.g. /var/lib/jenkins/cloud-city/.deployer-store-cache/cs_precise_mediawiki-10

tvansteenburgh commented 10 years ago

I think the best way to handle this is to not run charm proof against bundle charms. It's not necessary, as each charm will have been proofed individually already. I can't think of a better alternative.

abentley commented 10 years ago

A similar argument could be made for not running any charm tests when testing a bundle.

tvansteenburgh commented 10 years ago

Good point, I like that even better.