search

juju-solutions / interface-etcd

1 stars 5 forks source link

Final representation of the v1 interface for ETCD. #1

Closed lazypower closed 8 years ago

mbruzek commented 8 years ago

While testing this fix I see that the kubernetes unit does not have the etcd python library and fails with: unit-kubernetes-2: 2016-02-23 22:13:28 INFO unit.kubernetes/2.install logger.go:40 File "/var/lib/juju/agents/unit-kubernetes-2/charm/hooks/relations/etcd/peers.py", line 5, in unit-kubernetes-2: 2016-02-23 22:13:28 INFO unit.kubernetes/2.install logger.go:40 from etcd import remove_unit_from_cache unit-kubernetes-2: 2016-02-23 22:13:28 INFO unit.kubernetes/2.install logger.go:40 ImportError: No module named 'etcd'

johnsca commented 8 years ago

I'm a fan of the layer (and would probably like to fold it into the base layer), but it's not strictly necessary.

@when('cluster.ready', 'client.joined')
def send_connection(cluster, client):
    if hookenv.is_leader():
        client.provide_connection_info(cluster.hosts(), config['port'])
mbruzek commented 8 years ago

After much churn I can give this a +1 lgtm

lazypower commented 8 years ago

:tada: