search

juju-solutions / jujuresources

Manage binary resources for charms
MIT License
2 stars 4 forks source link

don't read arbitrary sized blobs into memory #1

Closed kapilt closed 9 years ago

kapilt commented 9 years ago

https://github.com/juju-solutions/jujuresources/blob/master/jujuresources/backend.py#L92

Glad to see this facility being developed, but some sanity around dealing with large files would be nice.

johnsca commented 9 years ago

Good point. There are a couple of places where I'm reading URLs of arbitrary size, as well. I've got a fix to chunk or limit things, but I need to fix / update the tests.