search

juju-solutions / jujuresources

Manage binary resources for charms
MIT License
2 stars 4 forks source link

make destination mandatory, or supply a default #2

Closed kwmonroe closed 9 years ago

kwmonroe commented 9 years ago

There's a big difference here:

install(foo, 'bar') vs install(foo, destination='bar')

I did the former by mistake, and poked around for more time than I'd like to admit because there wasn't any indication that install had failed. Please consider handling the None case here:

https://github.com/juju-solutions/jujuresources/blob/master/jujuresources/__init__.py#L79

Either with a default value or stderr("dont be silly"). Thanks!