juju-solutions / layer-apache-bigtop-base

Apache License 2.0
1 stars 5 forks source link

patch failure when charms fall back to git fetch #60

Closed kwmonroe closed 7 years ago

kwmonroe commented 7 years ago

The Bigtop 1.2.1 release is upon us, which means some of our ./resources/bigtop-1.2.0 patches have been merged into upstream branch-1.2.

This can cause deployment failures if our charms fall back to "git fetch" to pull down the required bigtop repo source. Typically, this is not a problem as charms should be using the bigtop-repo resource. However, somehow someway, @battlemidget found a way to hit this failure (note lines 5-6):

https://www.irccloud.com/pastebin/VbCmRHkG/

kwmonroe commented 7 years ago

To fix this, I removed the offending patches from our base layer:

https://github.com/juju-solutions/layer-apache-bigtop-base/commit/9dc81e8e7d83a1627dbf39ba4ab2d076fd856931

I'm now building the charms to pick up this change. I'll create a new bigtop-repo resource with the current upstream branch and re-release these charms shortly.

kwmonroe commented 7 years ago

Updated charms are on edge:

cs:~bigdata-charmers/hadoop-namenode-25
cs:~bigdata-charmers/hadoop-plugin-25
cs:~bigdata-charmers/hadoop-resourcemanager-27
cs:~bigdata-charmers/hadoop-slave-26
cs:~bigdata-charmers/hbase-19
cs:~bigdata-charmers/hive-8
cs:~bigdata-charmers/kafka-28
cs:~bigdata-charmers/mahout-18
cs:~bigdata-charmers/pig-19
cs:~bigdata-charmers/spark-50
cs:~bigdata-charmers/zeppelin-25
cs:~bigdata-charmers/zookeeper-31
kwmonroe commented 7 years ago

Had some issues with the previous charm revs on edge, but fixed them with this:

https://github.com/juju-solutions/layer-apache-bigtop-base/commit/451e214c48d7f5b1f40f620615ea0e17490c74f7

Here are the known-good charm revs:

cs:~bigdata-charmers/hadoop-namenode-26
cs:~bigdata-charmers/hadoop-plugin-26
cs:~bigdata-charmers/hadoop-resourcemanager-28
cs:~bigdata-charmers/hadoop-slave-27
cs:~bigdata-charmers/hbase-20
cs:~bigdata-charmers/hive-9
cs:~bigdata-charmers/kafka-29
cs:~bigdata-charmers/mahout-19
cs:~bigdata-charmers/pig-20
cs:~bigdata-charmers/spark-51
cs:~bigdata-charmers/zeppelin-26
cs:~bigdata-charmers/zookeeper-32

CI ran well on these. July 7 results are here (zookeeper and spark failures are unrelated to this fix):

http://bigtop.charm.qa/

Bundles have been updated and everything pushed to stable.