juju-solutions / layer-caas-base

Base layer for CaaS charms
Apache License 2.0
2 stars 7 forks source link

Example contains invalid spec, missing image #10

Closed stub42 closed 6 years ago

stub42 commented 6 years ago

The example in README.md has a pod spec using an imageDetails map instead of an image key. This is rejected by caas_base.pod_spec_set(), logging the error 'ERROR invalid pod spec: spec image is missing'.

johnsca commented 6 years ago

The imageDetails map was added with the support for the docker (soon to be osi-image) resource type. It's been working fine for me with that pattern for at least a week or two. I wonder if the error message is misleading and masking some other issue?

stub42 commented 6 years ago

It works as documented with 2.5 edge