juju-solutions / layer-caas-base

Base layer for CaaS charms
Apache License 2.0
2 stars 7 forks source link

README does not match pod_spec_set failure implementation #22

Open stub42 opened 5 years ago

stub42 commented 5 years ago

The README has pod_spec_set returning a boolean error to indicate success or failure. The implementation has it raising a subprocess.CalledProcessError on failure.

pod_spec_set should either return a boolean as documented, or raise a specific exception rather than a generic CalledProcessError (which is a leaky abstraction of the underlying pod-spec-set hook environment tool)