juju-solutions / layer-caas-base

Base layer for CaaS charms
Apache License 2.0
2 stars 7 forks source link

Unnecessary import magic will conflict with other layers #7

Closed stub42 closed 6 years ago

stub42 commented 6 years ago

caas_base.import_layer_libs appears to be doing magic imports of charms/layer as a convenience. This will cause conflicts with other layers, which are expecting standard Python packaging rules in this shared location. If caas_base needs magic imports, it should do so in a distinct namespace to avoid conflicts with other layers.

stub42 commented 6 years ago

Oh, this is also duplicated in the base layer :-(

Moving there.