search

juju-solutions / layer-cwr

Layer for building the Juju Jenkins CI env
Other
2 stars 5 forks source link

LXD in juju-2.1 should be treated like a regular cloud #101

Closed kwmonroe closed 7 years ago

kwmonroe commented 7 years ago

In juju-2.0, the lxd provider did not need any special credentials for remote users to do add-model, hence:

https://github.com/juju-solutions/layer-cwr/blob/master/scripts/cwr-helpers.sh#L230

In juju-2.1, lxd is treated like any other cloud (announcement). Now that 2.1 is GA, cwr needs to handle this.

The tricky part will be supporting users on both 2.0 and 2.1. I think we can do this by checking the output from juju add-model wont-be-added --credential invalid. If add-model works, run with it. If it doesn't, inform the user that they'll need to run the set-credentials action.

kwmonroe commented 7 years ago

Add min-version so cwr reqs 2.1 (helps standardize creds)

kwmonroe commented 7 years ago

Closed by https://github.com/juju-solutions/layer-cwr/pull/109. Released in cwr-66.