juju-solutions / layer-cwr

Layer for building the Juju Jenkins CI env
Other
2 stars 5 forks source link

run cwr in new container for each controller (fixes #114) #115

Closed kwmonroe closed 7 years ago

kwmonroe commented 7 years ago

Move the controller logic from add-models to run-cwr-in-container. This will cause us to run cwr in a new cwrbox for each controller.

This is NOT ideal. It drastically slows job execution since the jobs are no longer done in parallel by cwr. However, it seems cwr and/or bundletester don't honor separate controllers during deployment, so this is the quickest way to support jobs across multiple controllers.

ktsakalozos commented 7 years ago

LGTM +1 based on the code read through. @kwmonroe please go ahead and merge this as soon as you feel enough testing has gone into it. Thanks

ktsakalozos commented 7 years ago

Tested, seems fine!