search

juju-solutions / layer-cwr

Layer for building the Juju Jenkins CI env
Other
2 stars 5 forks source link

Copy the S3 credentials to the container. #118

Closed seman closed 7 years ago

seman commented 7 years ago

This branch copies the S3 credential file to the container. This credential file is used by cwr to upload the test result to S3.

The initial idea was to copy the the credentials file to the workspace directory but the directory is not created before the job creation and before the first build.

kwmonroe commented 7 years ago

I have some objection to the overall spirit of this. I'll abstain from +/- on this, but please consider my latest comment on https://github.com/juju-solutions/layer-cwr/issues/99 before we go much deeper in s3-per-action development.

pengale commented 7 years ago

I am +1 based on a read through of the code -- it looks like it does what it intends to.

I agree with @kwmonroe, though -- would be cleaner to specify this stuff once.

seman commented 7 years ago

I am going to land it since this is an update to the S3 publishing functionality. This current functionality will be broken without this update.

After talking to @kwmonroe, he has (damn you @kwmonroe) convinced me to add another action to accomplish this plus pushing all the artifacts to S3.