search

juju-solutions / layer-cwr

Layer for building the Juju Jenkins CI env
Other
2 stars 5 forks source link

Added S3 publishing to cwr-bundle, cwr-charm-pr and cwr-charm-release… #122

Closed seman closed 7 years ago

seman commented 7 years ago

Added S3 publishing to cwr-bundle, cwr-charm-pr and cwr-charm-release actions. Also, updated the bundlebuilder.py command-line interface code.

kwmonroe commented 7 years ago

Yuuuuuuuck. The sheer duplication in actions.yaml makes my eyes twitch. I understood the need to merge #118 to fix stuff that was already released, but I thought we were gonna go for an action to push cwr results off the box -- #99.

Once this stuff lands, it's gonna be tough to get out. Would you please consider waiting for a +2 before merging? I don't think all the dev/maint stakeholders have thought this through.

ktsakalozos commented 7 years ago

This PR seems to go against what is discussed here: https://github.com/juju-solutions/layer-cwr/pull/122

ktsakalozos commented 7 years ago

Also note that we might need to revert https://github.com/juju-solutions/layer-cwr/pull/110 should we dicide to implement https://github.com/juju-solutions/layer-cwr/pull/122

johnsca commented 7 years ago

Per Torsten, we're going to move forward with this, accept the additional technical debt, and refactor later to model storage properly in the Juju model.