There must be some combination where this works because it doesn't happen to me all the time. I'm guessing when I call the store-login action before the cwr charm is ready, I'm piggy-backing on some other reactive handler (ci_connection_updated or controllers_updated perhaps) to get the ready state.
I'll post working/broken combinations here if/when they come up. Meanwhile, one potential fix would be to move report_status into a helper lib that could be called from actions as well as reactive/cwr.py.
merlijn-sebrechts
commented
7 years ago
I've noticed that sometimes the
store-loginaction does not update the cwr status. After running the action successfully, i see:I verified the jenkins user does indeed have the usso-token, so it seems like our
report_status()function just isn't getting called:https://github.com/juju-solutions/layer-cwr/blob/master/reactive/cwr.py#L22
There must be some combination where this works because it doesn't happen to me all the time. I'm guessing when I call the
store-loginaction before the cwr charm is ready, I'm piggy-backing on some other reactive handler (ci_connection_updatedorcontrollers_updatedperhaps) to get thereadystate.I'll post working/broken combinations here if/when they come up. Meanwhile, one potential fix would be to move
report_statusinto a helper lib that could be called from actions as well as reactive/cwr.py.