search

juju-solutions / layer-cwr

Layer for building the Juju Jenkins CI env
Other
2 stars 5 forks source link

Move the plugins installation logic to the Jenkins #9

Open ktsakalozos opened 7 years ago

ktsakalozos commented 7 years ago

Installing plugins is a common functionality already supported by the jenkins-entension interface (https://github.com/juju-solutions/interface-jenkins-extension/blob/master/provides.py#L62). We should move the check of the availability and optional restart of Jenkins to the Jenkins side.

johnsca commented 7 years ago

We're already installing the plugins via the config options; can we just drop this entirely from the charm?

johnsca commented 7 years ago

Also, that interface layer needs some work. There shouldn't be any implementation in the interface layer.

ktsakalozos commented 7 years ago

+1 x 2 Agree to both of them.

ktsakalozos commented 7 years ago

Wait! I am sceptical about dropping the functionality from the charm. Suppose we do that, then we would have a charm deployed only from bundles, or requiring functionality from another charm (jenkins) that is outside the interface.

No objections on removing the install plugin functionality from the interface and use only the python-jenkins library to install plugins. There is only one open issue to that, installation of plugins may require a jenkins restart.

kwmonroe commented 7 years ago

@ktsakalozos we manually install plugins for cwr here:

https://github.com/juju-solutions/layer-cwr/blob/master/reactive/cwr.py#L231

Is this issue still valid?