search

juju-solutions / layer-flannel

0 stars 2 forks source link

Remove flakey bootstrap script #9

Closed lazypower closed 8 years ago

lazypower commented 8 years ago

Refactor out the script into the reactive module This branch strips most of the flakey and often misunderstood bootstrap.sh file. in favor of the reactive module code and python native tooling.

The only leftover from bootstrap.sh is the etcdctl configuration run command, due to subprocess stripping the quotes and malforming the json.

This PR depends on a new cut of charms.docker: juju-solutions/charms.docker#23

AdamIsrael commented 8 years ago

👍 to refactoring. Nothing in the code jumps out to me as wrong, but I'm not clear on the steps to take to fully test the changes.

lazypower commented 8 years ago

@AdamIsrael good point, as a middle layer it becomes extremely difficult to test.

It does however compile into a "flannel" charm by itself, and can be deployed. Verification of ifconfig and grepping for flannel with the configured CIDR would be a good test...

What I was doing for validation was building kubernetes and running the deployment (worst possible test case scenario ever, build this other thing and deploy it and if it works its good(?!)) However due to time constraints this is what was done.

I'm not opposed to including an amulet test in the layer if thats required to validate. LMK how you would like to procede and I will accomodate