Fixed the should_gate test.

juju-solutions / matrix

Automatic testing of big software deployments under various failure conditions

Other

8 stars 9 forks source link

Fixed the should_gate test. #109

Closed pengale closed 7 years ago

pengale commented 7 years ago

It was looking in the context, rather than context.config, for the ha key. This would only fail tests that were failing anyway, but it clobbered the original Exception, and replaced it with an Exception raised by my broken check. Whoops.

@kwmonroe @johnsca @abentley @seman

kwmonroe commented 7 years ago

@petevg travis seems to be unhappy with your shenanigans.

pengale commented 7 years ago

@kwmonroe Eek. Had another bug. This time I pushed a more complete fix, along with some proper exit codes. Matrix now exits 101 if it ran into a TestFailure, and stuffs the generic exceptions under a generic exit code of 1. Makes things much easier to test!