juju-solutions / matrix

Automatic testing of big software deployments under various failure conditions
Other
8 stars 9 forks source link

Remove internal Timeout for matrix tests. #129

Closed pengale closed 7 years ago

pengale commented 7 years ago

This is an Alexandrian solution to our "matrix is too green" bug. (https://github.com/juju-solutions/matrix/issues/123)

It also makes things a lot nicer in general. External tools calling matrix still have to include a timeout, because the existing matrix timeout only covered hangs during a test run; hangs during setup or teardown could still lead to a hung matrix. And External tools with a timeout still have to worry about cleaning up matrix models; having an internal timeout cleanup that only helps in some cases isn't necessary.

This also simplifies the code, and removes a command line param. A win all around, I think.

@johnsca @kwmonroe