search

juju-solutions / matrix

Automatic testing of big software deployments under various failure conditions
Other
8 stars 9 forks source link

Use ubuntui for consistency with conjure-up #35

Closed johnsca closed 7 years ago

johnsca commented 7 years ago

Fixes #33

There's not a lot of overlap on the widgets (mainly because Matrix has a pretty simplistic UI), but the integration was easy and we at least get an orange header out of it. And moving forward, this should encourage us to converge our widgets and get better reuse.

I'm not a big fan of the hard requirement for a high-color terminal, but it's the only way to honor the color scheme and I guess it's supported by most moderns terms.

johnsca commented 7 years ago

I had started to poke at adding a Cancel button, in the style of http://conjure-up.io/images/ss.png, because it seemed like it would be nicer than only relying on ctrl-c, but I couldn't get the quit handler to work properly with running tasks, and the widgets in ubuntui are missing some of the niceties from conjure-up (Ubuntu-Solutions-Engineering/urwid-ubuntu#3).

adam-stokes commented 7 years ago

I'm not a big fan of the hard requirement for a high-color terminal, but it's the only way to honor the color scheme and I guess it's supported by most moderns terms.

Going to track this here: https://github.com/Ubuntu-Solutions-Engineering/urwid-ubuntu/issues/4

pengale commented 7 years ago

The colors in the juju debug log are pretty. +1

(Not just because the colors are pretty -- code also looks good, and this works on my machine.)