search

juju-solutions / matrix

Automatic testing of big software deployments under various failure conditions
Other
8 stars 9 forks source link

Create and destroy model per test #43

Closed johnsca closed 7 years ago

johnsca commented 7 years ago

This also includes @bcsaller's TUIView improvements.

pengale commented 7 years ago

This looks good, and runs well against a local controller on my laptop.

One minor nitpick: it would be nice to have a "model destroyed" message at the very end. As it was, the last message in my log was "destroying model ...", and I thought that it had hung.

LGTM/+1

johnsca commented 7 years ago

@petevg Technically, the model is not destroyed when that API call returns, it has just sent the request off to the controller. I added a log message to indicate that it returned, at least, but do you think we should actually block until the model is gone to verify that it was successfully removed?

@bcsaller I added a --keep-models flag, and commented out the timeline action for now.

pengale commented 7 years ago

@johnsca Works great. Looks good. +1 (I don't think that we need to block to make sure the model is destroyed for now -- the user can clean up old models if matrix leaves a mess every once in a while.)