juju-solutions / matrix

Automatic testing of big software deployments under various failure conditions
Other
8 stars 9 forks source link

Extract perform action #82

Closed abentley closed 7 years ago

abentley commented 7 years ago

This branch extracts perform_action from main.glitch().

For Hammer Time, Task, Rule, Bus, Context all don't seem necessary. I have been able to execute a plan using main.glitch(), but it requires more set-up than seems appropriate. By extracting perform_action, glitch plans become much easier to use.

In order to do this refactoring, I added unit tests for main.glitch() and perform_action.

It passes tox -r. I didn't see a preferred linter, so I used flake8.

pengale commented 7 years ago

This LGTM, and "tox -e functional -r" runs well.