search

juju-solutions / review-queue

Juju Review Queue webapp
4 stars 4 forks source link

Handle charms with terms. #54

Closed tvansteenburgh closed 7 years ago

tvansteenburgh commented 7 years ago

In order to download charms with terms, we need to be auth'd to the charmstore, and we need to agree to the charm terms before downloading.

A charmstore user/pass will be passed in via charm config. We then use pexpect to charm login dynamically as needed. Any other method would be problematic since the charmstore macaroons and sso token will eventually expire, making it necessary to login again.

Also added a catch-all 500 view just for the sake of aesthetics.

Fixes #46.

johnsca commented 7 years ago

This LGTM :+1: but I had a couple of non-blocking comments:

I asked for confirmation on juju/charmstore#618 as to whether that fix has already been released as it was scheduled to, so we could maybe remove that work-around.

I recall Casey mentioning removing the go cookies explicitly, but your comment in the login function indicates that it will always do the right thing. I just wanted to confirm that explicitly removing the go cookies is not necessary.