juju-solutions / review-queue

Juju Review Queue webapp
4 stars 4 forks source link

Test results not matching test #58

Open johnsca opened 7 years ago

johnsca commented 7 years ago

The test results on https://review.jujucharms.com/reviews/21 are inconsistent. Some of them are to Jenkins jobs that no longer exist, but the AWS result has imported results but apparently from the wrong job.

tvansteenburgh commented 7 years ago

Revq receives a callback from jenkins after a test job starts. At that point we know the jenkins build number for the test, and can add the link to the console output to the Test Results table while the job is running, so people can watch the test running if they want.

After the jenkins job completes, we get another callback, and that's when we try to import the test result json (so we have them even after the jenkins job is deleted). If we never get that final callback (test job ends abnormally, network failure, revq doesn't respond, etc), we'll try to find and import the test result json anyway after a given timeout period.

Not sure how/why we're getting test results for the wrong job (although I haven't looked into it yet), but I saw at least one other case of that, and if I recall, it pointed to the same incorrect results (maybe a clue?). This is also mentioned in #48.