juju / 1.25-upgrade

Tools to upgrade and move a 1.25 environment to a 2.2.4+ controller
4 stars 7 forks source link

Fix container instance id rewriting #67

Closed babbageclunk closed 5 years ago

babbageclunk commented 5 years ago

The exported model had container instance-ids like juju-machine-1-lxd-2, when they should have been juju-b7e869-1-lxd-2 in order for remove-machine (or anything else that needed to talk to LXD) to work correctly.

Fixes https://bugs.launchpad.net/juju/+bug/1808034

Also got rid of erroneous juju/juju imports that were added inadvertently. On top of bloating the binary size, they also meant that juju/utils was being included twice - once directly, and once via the juju/juju vendor directory (because juju/juju was checked out to a 2.5-based branch). That caused a panic because juju/utils has an init() that registers a transport for the file: protocol, and RegisterProtocol was complaining that it was already registered.

babbageclunk commented 5 years ago

1.25 upgrade - container instance ids rewritten incorrectly