search

juju / amulet

Testing harness and tools for Juju Charms
Other
17 stars 33 forks source link

Move tmp dir creation so setup() can be run more than once #103

Closed tvansteenburgh closed 9 years ago

tvansteenburgh commented 9 years ago

Fixes this error: http://reports.vapour.ws/all-bundle-and-charm-results/charm-bundle-test-parent-1003/charm/azure/3

johnsca commented 9 years ago

I'd like to see deploy_w_timeout changed to use the timeout_gen, but it's not the end of the world.

tvansteenburgh commented 9 years ago

@johnsca I don't see how we can use timeout_gen since in the one place where deploy_w_timeout is used, the context that it yields to blocks until the timeout would be expired anyway. Am I missing something?

johnsca commented 9 years ago

Ah, you're right. Wrapping a blocking call (subprocess) is the case where the SIGALRM-based timeout is better. Ignore my comment.