search

juju / charm-helpers

Apache License 2.0
18 stars 127 forks source link

Rename wsgi-rotation to wsgi-socket-rotation #833

Closed dosaboy closed 1 year ago

dosaboy commented 1 year ago

not sure why pep8 is failing here, it works fine when i run locally. i have rebase and updated.

zhhuabj commented 1 year ago

LGTM - thanks for the changes

ajkavanagh commented 1 year ago

@dosaboy thanks for the patch. Please could you add to the description above why these changes are necessary and, also, as it is will cause a corresponding change in charms (the config var is changing), what charms it is affecting. At the moment, this looks like a breaking change, but it's not possible to see what is breaking. Thanks!

dosaboy commented 1 year ago

@ajkavanagh thanks for the review. I have addressed your points in the commit msg. This is not a breaking change since the patches to implement it in the charms are blocked on this landing first.