search

juju / charm-helpers

Apache License 2.0
18 stars 127 forks source link

pep8: Use isinstance() #838

Closed freyes closed 1 year ago

freyes commented 1 year ago

Rule E721 requires the use of isinstance() instead of "type() == SomeType".

https://www.flake8rules.com/rules/E721.html

freyes commented 1 year ago

Example of the failure - https://github.com/juju/charm-helpers/actions/runs/5790562939/job/15693844816?pr=834

freyes commented 1 year ago

abandoning in favor of https://github.com/juju/charm-helpers/pull/839