juju / charm-helpers

Apache License 2.0
18 stars 127 forks source link

cherry-pick the fix for lp bug 2021550 to zed branch #847

Closed zhhuabj closed 11 months ago

zhhuabj commented 1 year ago

cherry-pick the commit 996f241 and 1a90eb0 to zed branch

lathiat commented 11 months ago

I think the topic of the pull request (Currently: Zed lp2021550) needs to be set to something more indicative of the actual fix.

Additionally we should try to add descriptions to the commits, not just Subject lines only.

zhhuabj commented 11 months ago

hi @lathiat , I have updated PR title and RP description, thanks for the review