search

juju / charm-tools

Tools for charm authors and maintainers
Other
42 stars 64 forks source link

Prune GIT environment variables when using Python from buildenv #633

Closed fnordahl closed 1 year ago

fnordahl commented 1 year ago

At present we call out to Python provided by the build environment to create a correct wheelhouse.

However, we are not pruning GIT related environment variables set by the snap. This in turn makes git clone fail when the git binary from the build environment attempts to use git resources in the snap, which may be of a different version.

Fixes #632

ajkavanagh commented 1 year ago

So this change will assume that git is installed on the host system, bypassing the version in the snap. Git is almost always installed so it should be okay?

fnordahl commented 1 year ago

So this change will assume that git is installed on the host system, bypassing the version in the snap. Git is almost always installed so it should be okay?

Essentially yes, this goes in hand with our need for using Python from the build environment and not from the snap. Commit 2482f0f104d31f6f3f50e5645d0705bb9b738a72 changed the default behavior, and at the same time added a option to use the old behavior.

So if anyone would be harmed by this change they have a way to override it.