juju / charm-tools

Tools for charm authors and maintainers
Other
42 stars 64 forks source link

Missing build packages #638

Closed fnordahl closed 1 year ago

fnordahl commented 1 year ago

The change of default for using Python and associated tools from the build environment introduced in commit 2482f0f104d31f6f3f50e5645d0705bb9b738a72 and commit 725d2cb4d74187a02ffcb2e4ffcc5ed8c878ff52 are correct and required for delegating buid-on / run-on decisions to charmcraft.

However, they also introduce a regression on the form of missing build-packages.

Adding the following to a charmcraft.yaml solves it:

    build-packages:
      - virtualenv
      - git

However at this point in time there may be a large estate of charms that currently do not define this.

Furthermore the charmcraft reactive plugin most likely should declare these build-packages as bare minimum default anyway.

Perhaps we need to workaround this issue?