juju / charm-tools

Tools for charm authors and maintainers
Other
42 stars 64 forks source link

Pin pip<23.1 and setuptools<67 to allow PEP-440 non compliance #653

Closed ajkavanagh closed 1 year ago

ajkavanagh commented 1 year ago

PEP-440 is more strict about requirement lines. As an example:

pytz>dev

is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install.

The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available.

Fixes-Bug: #652

Description of change

Checklist

ajkavanagh commented 1 year ago

The integration test failure is unrelated to the change; sadly it looks like a networking issue within charmcraft.