juju / charm-tools

Tools for charm authors and maintainers
Other
42 stars 64 forks source link

(backport) pin pip<23.1 and setuptools<67 #654

Closed ajkavanagh closed 1 year ago

ajkavanagh commented 1 year ago

to allow PEP-440 non compliance.

(backported relevant parts from master branch in #653)

PEP-440 is more strict about requirement lines. As an example:

pytz>dev

is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install.

The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available.

Fixes-Bug: #652

Description of change

Checklist