juju / charm-tools

Tools for charm authors and maintainers
Other
42 stars 64 forks source link

setup: pin macaroonbakery<1.3.3 for python3.6 #671

Closed lathiat closed 8 months ago

lathiat commented 8 months ago

macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which makes it incompatible with python 3.6 and v1.3.3 was released in a broken state[1].

lathiat commented 8 months ago

I'm still having trouble with octavia/ussuri failing to build due to macaroonbakery/protobuf (https://review.opendev.org/c/openstack/charm-octavia/+/902746).

It's only broken for Python3.6 (Bionic) which only effects ussuri, victoria is fine since it only needs Python3.8 (Focal).

The specific issue is charm-tools < 3.0.0 -> libcharmstore -> theblues -> macaroonbakery

charm-tools 3.x actually installs and works fine on python3.6 (and works to build the charm) because libcharmstore was dropped, but the stable charms currently tend to pin charm-tools to <3.0.0 (or == 2.8.x)