feat: Add new hook types for Pebble check events (OP046)

juju / charm

Parsing and testing Juju charms

Other

13 stars 59 forks source link

feat: Add new hook types for Pebble check events (OP046) #432

Closed tonyandrewmeyer closed 3 months ago

tonyandrewmeyer commented 3 months ago

Add new hook types for the upcoming Pebble check events work. See OP046. New hook names are:

<container>-pebble-check-failed
<container>-pebble-check-recovered

This also removes the pebble-change-updated hook, since adding support for pebble-change-updated-notice events was reverted (pre-release) from Juju and there are no current plans to add it back (see OP045).

This is required for the main Juju PR adding check event support.

jujubot commented 3 months ago

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

jujubot commented 3 months ago

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

SimonRichardson commented 3 months ago

PR to add deprecation warning https://github.com/juju/charm/pull/433