search

juju / charmstore

The charm store server.
http://gopkg.in/juju/charmstore.v5
GNU Affero General Public License v3.0
15 stars 37 forks source link

internal/{charmstore,v5}: fix list results #786

Closed rogpeppe closed 6 years ago

rogpeppe commented 6 years ago

When some list results had different ACLs from others, we filtered out all but the most recent revision, so we could fail to show any results even though some results could be shown.

We fix that by changing ListQuery so that it returns all matching charms that are in different channels; then we filter those results after retrieving from MongoDB.

This changes the semantics of sorting by owner because sorting is now done based on the returned results which don't necessarily contain the actual owner, so we sort by the User field in the returned URL, which means that promulgated charms will always be returned first in that case.

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2174/

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2175/

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2176/

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2177/

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2178/

rogpeppe commented 6 years ago

:shipit:

jujugui commented 6 years ago

Status: merge request accepted. Url: http://ci-gce.jujugui.org:8080/job/charmstore-merge