search

juju / charmstore

The charm store server.
http://gopkg.in/juju/charmstore.v5
GNU Affero General Public License v3.0
15 stars 37 forks source link

internal/monitoring: Fix endpoint metrics. #847

Closed mhemmings closed 6 years ago

mhemmings commented 6 years ago

Here we fix the endpoint metrics so that that they are neatly grouped rather than outputting the entity names and causing time series pollution. (e.g. /wordpress/meta/common-info, /mysql/meta/common-info etc are now simply tracked as /:id/meta/common-info).

Kind (which was very buggy and at times random) is replaced with Endpoint which holds this above info. The rough metrics on v4 are removed too.

This PR will give us the ability to gain lots of insights on API usage per endpoint. The next PR will add granular metrics for metadata, under a separate namespace to keep Prometheus clean and queryable.

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2281/

jujugui commented 6 years ago

Refer to this link for build results (access rights to CI server needed): http://ci-gce.jujugui.org:8080//job/charmstore/2282/