search

juju / juju-bundlelib

A Python library for working with Juju bundles.
GNU Lesser General Public License v3.0
1 stars 14 forks source link

Improve the Reference model. #20

Closed frankban closed 9 years ago

frankban commented 9 years ago

Also avoid installing sphinx as a system dependency, and fix the docs generation.

jujugui commented 9 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-bundlelib/21/ Test FAILed.

mitechie commented 9 years ago

Manually added sysdeps to the ci server. However we can't run sysdeps automatically via check. jenkins doesn't have access on the system.

mitechie commented 9 years ago

:+1: no QA aside from the aptdeps issue.

bac commented 9 years ago

Code :+1: with a few suggestions.

So tox implicitly requires sudo now, thus the CI failure?

frankban commented 9 years ago

Not sure about the CI failure, tox does not require sudo and sphinx is installed in a venv. Thanks for the reviews! :shipit:

jujugui commented 9 years ago

Status: merge request accepted. Url: http://localhost:8080/job/juju-bundlelib-merge