Improve unit placement and integration tests.

juju / juju-bundlelib

A Python library for working with Juju bundles.

GNU Lesser General Public License v3.0

1 stars 14 forks source link

Improve unit placement and integration tests. #24

Closed frankban closed 9 years ago

frankban commented 9 years ago

This branch fixes some errors when parsing the bundle to generate the change set. Those errors were not detected by the functional test because its implementation was naive: we did not realize the generator object, which of course is always True.

So the functional tests are now fixed and the following two scenarios are handled:

a unit is placed to a service;
a service does not define num_units.

This should fix some of the QA errors encountered at https://github.com/juju/juju-gui/pull/720

jujugui commented 9 years ago

Test FAILed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-bundlelib/32/ Test FAILed.

frankban commented 9 years ago

QA: make fcheck

mitechie commented 9 years ago

:+1: ty for the update

frankban commented 9 years ago

Thank you Rick for the review! :shipit:

frankban commented 9 years ago

:shipit:

jujugui commented 9 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-bundlelib-merge