search

juju / juju-bundlelib

A Python library for working with Juju bundles.
GNU Lesser General Public License v3.0
1 stars 14 forks source link

Do not crash with a traceback if a machine value is unset #33

Closed frankban closed 9 years ago

frankban commented 9 years ago

Handle the case in which the machines section includes a machine without a definition, like:

machines:
    1:

Both validation and changeset generation crashed with a YAML like that. The tests should demonstrate the new behavior.

Please make check.

jujugui commented 9 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-bundlelib/44/ Test PASSed.

makyo commented 9 years ago

:+1: thanks for the fix!

bac commented 9 years ago

:+1:

jujugui commented 9 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-bundlelib/45/ Test PASSed.

frankban commented 9 years ago

Thanks for the reviews! :shipit:

jujugui commented 9 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-bundlelib-merge