Introduce expose change.

juju / juju-bundlelib

A Python library for working with Juju bundles.

GNU Lesser General Public License v3.0

1 stars 14 forks source link

Introduce expose change. #39

Closed frankban closed 8 years ago

frankban commented 8 years ago

Handle validating the service expose fields. Generate proper expose changes when required.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-bundlelib/55/ Test PASSed.

frankban commented 8 years ago

Tests: make check.

QA: save this bundle as /tmp/media.yaml:

services:
  mediawiki:
    charm: cs:trusty/mediawiki-3
    num_units: 1
    expose: true
  mysql:
    charm: cs:trusty/mysql-29
    num_units: 1
series: trusty
relations:
- - mediawiki:db
  - mysql:db

The run devenv/bin/getchangeset /tmp/media.yaml and ensure an expose-2 change is included in the output.

hatched commented 8 years ago

:+1:

makyo commented 8 years ago

:+1: QA :ok:

makyo commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-bundlelib-merge