juju / juju-gui-charm

Charm for Juju GUI.
GNU Affero General Public License v3.0
2 stars 16 forks source link

Remove the juju-gui-source config option and related code. #17

Closed jcsackett closed 8 years ago

jcsackett commented 8 years ago

QA:

Deploy the charm into a bootstrapped environment. It should get to a running charm w/o difficulty.

Confirm the juju-gui-source setting is gone.

Monkey with other settings, and if you like upgrade the charm--everything should work without error.

hatched commented 8 years ago

:+1: But I notice that that code used git but the git install wasn't removed. Is it still being used elsewhere or was this just an oversight?

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/4/ Test PASSed.

jcsackett commented 8 years ago

@hatched yeah, the git install could be removed as well, and has been.

jujugui commented 8 years ago

Test PASSed. Refer to this link for build results (access rights to CI server needed): http://ci.jujugui.org:8080//job/juju-gui-charm/6/ Test PASSed.

makyo commented 8 years ago

:+1: QA OK

jcsackett commented 8 years ago

:shipit:

jujugui commented 8 years ago

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-charm-merge